[1.x] Improvment even number rule performance #100
Conversation
| public function check_float_number_is_even() | ||
| { | ||
| $rules = ['even_number' => [new ValidEvenNumber]]; | ||
| $data = ['even_number' => '754.00']; |
There was a problem hiding this comment.
I’ve recently noticed some unfairness toward this Repo, but I sincerely appreciate you submitting this PR and supporting it.
My question is: Does checking for even or odd in decimal numbers have any specific meaning in mathematics?
There was a problem hiding this comment.
Thank you. It doesn't mean anything. But in your code, the same number fails the test... You can try. Even though the number is even....
There was a problem hiding this comment.
But in your code, the same number fails the test
Therefore, the test that has been written does not provide adequate coverage.
First, the test should be refactored to address this issue.
The best approach would be to use data providers in the PHPUnittest to cover a variety of values effectively.
There was a problem hiding this comment.
I apologize. Does the current test provide adequate coverage?? If it did, I think the code on decimal numbers should not be in trouble...
What exactly is your idea? Can you provide a reference?
There was a problem hiding this comment.
Does the current test provide adequate coverage??
No, the tests are not sufficient. For example, you are using gmp, but there are no tests for large numbers, or for cases like 2abc and ...
Do we need to write a separate test for each case? The answer is NO.
You can use data providers to cover all these cases with a single method. Please refer to the link below.
https://docs.phpunit.de/en/10.5/writing-tests-for-phpunit.html#data-providers
milwad-dev
changed the title
| public function check_float_number_is_even() | ||
| { | ||
| $rules = ['even_number' => [new ValidEvenNumber]]; | ||
| $data = ['even_number' => '754.00']; |
There was a problem hiding this comment.
Does the current test provide adequate coverage??
No, the tests are not sufficient. For example, you are using gmp, but there are no tests for large numbers, or for cases like 2abc and ...
Do we need to write a separate test for each case? The answer is NO.
You can use data providers to cover all these cases with a single method. Please refer to the link below.
https://docs.phpunit.de/en/10.5/writing-tests-for-phpunit.html#data-providers
1- Improved ValidEvenNumber rule performance
2 - Fixed the issue with decimal numbers