zbobr_fix-52-update-commands#319
Open
milyin wants to merge 6 commits into
Open
Conversation
5 tasks
Add a new `Select` variant to `TaskSubcommand` that provides the same ready-task selection behavior previously available via `task list --select`. The `--select` flag is removed from the `List` variant. `task process --select` remains unchanged. Updates comment in cli.rs and adds tests. Closes part of #318 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change --logs from a simple boolean flag (SetTrue) to an optional-value flag using Append action with num_args=0..=1 and require_equals=true. Supported forms: --logs, --logs=true, --logs=false. Space-separated form (--logs true) is supported via the hoisting logic in parse_cli which joins the value with '='. Multiple occurrences use last-value-wins semantics. Updates the hoisting logic to handle OptionalValue args: these consume the next token only if it doesn't start with '-', and join it with '=' for clap compatibility. Closes #318 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Only consume the next token as a --logs value when it is a valid boolean literal (true/false), preventing theft of positional args - Normalize space-separated --logs true/false in the pre-subcommand path so the advertised forms work regardless of placement - Change logs field from Vec<String> to Vec<bool> so clap rejects invalid values (e.g. --logs=maybe) at parse time Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies that --logs=maybe is rejected at parse time now that the field uses Vec<bool> instead of Vec<String>. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves milyin-zenoh-zbobr/tasks#52