Fix #47: command line arguments and toml syntax mismatch#52
Open
milyin wants to merge 5 commits into
Open
Conversation
12 tasks
The [executor] section is now optional in TOML config files, aligning with the CLI argument design where executor arguments use an empty prefix (e.g., --claude-default-model instead of --executor-claude-default-model). The executor configuration already supports the Optional type with unwrap_or_default() in generic_config.rs, so this is purely a documentation and sample file update to reflect the actual usage pattern. - Removed [executor.*] sections from zbobr.toml, zbobr-fs.toml, zbobr.toml.sample, and zbobr.toml.fs.sample - Users can still provide executor config via TOML if needed - Backward compatibility maintained: existing TOML files with [executor] sections will continue to parse correctly - CLI arguments continue to work as before Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The [executor] section in TOML files is now optional. Users can configure executor settings via environment variables or CLI flags instead of TOML. Updated README.md to reflect that [executor.copilot] section can be omitted, and configuration can be done via environment variables (ZBOBR_COPILOT_GITHUB_TOKEN). This aligns with the earlier change to remove [executor] sections from sample TOML files and matches the CLI argument design where executor arguments lack the 'executor.' prefix. Checklist item: readme-executor-refs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update README.md documentation to clarify that the [executor] TOML section and its subsections ([executor.copilot], etc.) are entirely optional and can be omitted. Users can configure via CLI flags or environment variables instead. This aligns with the actual implementation where executor config uses Option<T> with unwrap_or_default() and matches the CLI design where executor arguments lack the 'executor.' prefix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Keep main's executor sections in TOML files (provides default model configs) - Keep main's CLI enhancements (push commits after work execution) - Keep work branch's README clarifications (executor sections are optional) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.