Skip to content

Fix #44: decompose stage#85

Open
milyin wants to merge 6 commits into
mainfrom
zbobr_fix-44-umbrella-stages
Open

Fix #44: decompose stage#85
milyin wants to merge 6 commits into
mainfrom
zbobr_fix-44-umbrella-stages

Conversation

@milyin
Copy link
Copy Markdown
Owner

@milyin milyin commented Mar 4, 2026

No description provided.

@milyin milyin mentioned this pull request Mar 4, 2026
23 tasks
milyin and others added 5 commits March 4, 2026 01:54
- Add DecomposePlanning and Decomposing variants to Stage enum
- Update Stage::milestone_name() and Stage::from_milestone_name()
- Update Stage::priority() to include new stages
- Add Decomposer variant to Role enum
- Update Role::as_str() to include decomposer
- Update Role conversion implementations (From, TryFrom, FromStr)
- Add umbrella bool field to Task struct

Related to: umbrella-flag-add, stage-enum-update, decomposer-role-add

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add GoDecomposePlan signal to Signal enum with priority 3.5
- Update Signal::name(), Signal::all(), and Signal::target_role()
- Update Signal::from_str() to handle decompose_plan signal
- Add Decomposer role to match statements in:
  - zbobr-dispatcher/src/cli.rs (process_task_by_stage and routing)
  - zbobr-dispatcher/src/mcp/traits.rs (retry_signal)
  - zbobr-dispatcher/src/mcp/common.rs (MCP router creation)
  - zbobr-dispatcher/src/prompts.rs (prompt generation)
- Fix umbrella flag handling in GitHub backend
- Add DecomposePlanning and Decomposing to stage_description in GitHub backend
- Create new DecomposerMcp implementation in zbobr-dispatcher/src/mcp/decomposer.rs
- Add decomposer_tools and decomposer_instructions
- Export DecomposerMcp and decomposer_instructions from lib.rs
- Update mcp/mod.rs to include decomposer module exports

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add DecomposePlanning and Decomposing to desired_stages in setup
- Add umbrella flag to the flags array for label creation
- Update setup() to create umbrella:flag label with proper color and description

All existing tests (43) continue to pass.

Related to: github-backend-setup, github-setup-umbrella, test-validation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add DecomposePlanning and Decomposing stages to the Workflow Stages table
- Update Stage Flow diagram to show decomposition path for umbrella tasks
- Add comprehensive signal labels (go_prepare, go_analyse, go_plan, go_decompose_plan, etc.)
- Add flag:umbrella label documentation
- Add separate section for Creating Umbrella Tasks with step-by-step instructions
- Document the decomposition workflow for multi-repository tasks

Related to: documentation-update

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the Analyser role finalization in zbobr-dispatcher/src/cli.rs to check
the umbrella flag and conditionally signal:
- If umbrella == true -> signal GoDecomposePlan for decomposition workflow
- If umbrella == false -> signal GoPlan for regular workflow

This fixes the issue where umbrella tasks were incorrectly following the regular
planning workflow instead of the decomposition workflow.

All 16 existing tests pass after this change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant