Zbobr fix 44 enhance umbrella decomposition#88
Open
milyin wants to merge 7 commits into
Open
Conversation
- Add DecomposePlanning and Decomposing variants to Stage enum - Update Stage::milestone_name() and Stage::from_milestone_name() - Update Stage::priority() to include new stages - Add Decomposer variant to Role enum - Update Role::as_str() to include decomposer - Update Role conversion implementations (From, TryFrom, FromStr) - Add umbrella bool field to Task struct Related to: umbrella-flag-add, stage-enum-update, decomposer-role-add Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add GoDecomposePlan signal to Signal enum with priority 3.5 - Update Signal::name(), Signal::all(), and Signal::target_role() - Update Signal::from_str() to handle decompose_plan signal - Add Decomposer role to match statements in: - zbobr-dispatcher/src/cli.rs (process_task_by_stage and routing) - zbobr-dispatcher/src/mcp/traits.rs (retry_signal) - zbobr-dispatcher/src/mcp/common.rs (MCP router creation) - zbobr-dispatcher/src/prompts.rs (prompt generation) - Fix umbrella flag handling in GitHub backend - Add DecomposePlanning and Decomposing to stage_description in GitHub backend - Create new DecomposerMcp implementation in zbobr-dispatcher/src/mcp/decomposer.rs - Add decomposer_tools and decomposer_instructions - Export DecomposerMcp and decomposer_instructions from lib.rs - Update mcp/mod.rs to include decomposer module exports Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add DecomposePlanning and Decomposing to desired_stages in setup - Add umbrella flag to the flags array for label creation - Update setup() to create umbrella:flag label with proper color and description All existing tests (43) continue to pass. Related to: github-backend-setup, github-setup-umbrella, test-validation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add DecomposePlanning and Decomposing stages to the Workflow Stages table - Update Stage Flow diagram to show decomposition path for umbrella tasks - Add comprehensive signal labels (go_prepare, go_analyse, go_plan, go_decompose_plan, etc.) - Add flag:umbrella label documentation - Add separate section for Creating Umbrella Tasks with step-by-step instructions - Document the decomposition workflow for multi-repository tasks Related to: documentation-update Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the Analyser role finalization in zbobr-dispatcher/src/cli.rs to check the umbrella flag and conditionally signal: - If umbrella == true -> signal GoDecomposePlan for decomposition workflow - If umbrella == false -> signal GoPlan for regular workflow This fixes the issue where umbrella tasks were incorrectly following the regular planning workflow instead of the decomposition workflow. All 16 existing tests pass after this change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enhancements implemented: 1. Add CreateTaskParam struct and create_task() MCP tool to decomposer 2. Implement multi-repo detection in Preparator - routes multi-repo umbrella tasks directly to GoDecomposePlan, skipping Analyser 3. Implement stage-aware decomposer MCP with conditional create_task tool 4. Update decomposer instructions for DecomposePlanning and Decomposing stages 5. Add create_task method to RoleSession for task creation permissions 6. Update decomposer finalization logic to handle both stages: - DecomposePlanning -> GoDecompose signal - Decomposing -> Done transition 7. Add GoDecompose signal (priority 3.7) between GoDecomposePlan and GoWork All tests pass (76 tests). Multi-repo umbrella tasks now bypass Analyser. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.