Revert "touch_handler: Fix scroll up behavior on Firefox Android" #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 344a237. The previous behavior is more correct due to the use of preventDefault() and the commit was introduced only as a workaround. As of [1], the underlying issue in Firefox has been fixed and downward swipes to scroll up are no longer ignored every other attempt. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1847305 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1853075 [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1724755 Signed-off-by: Andrew Gunnerson <[email protected]>
|
Unmarking as draft. Firefox 122.0 was released today and I've confirmed that the scrolling issues are indeed fixed! The workaround from 344a237 is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 344a237.
The previous behavior is more correct due to the use of
preventDefault()and the commit was introduced only as a workaround. As of [1], the underlying issue in Firefox has been fixed and downward swipes to scroll up are no longer ignored every other attempt.[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1847305
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1853075
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1724755
Do you follow the guidelines?
122.0a1 #2015990370, 825175e8ac+I'm marking this PR as a draft temporarily because the upstream fix is only in Firefox nightly builds. Once Firefox 122 is released, this can be merged.