Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with LinkAce service #2313

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Integration with LinkAce service #2313

merged 1 commit into from
Jan 26, 2024

Conversation

MDeLuise
Copy link
Contributor

Do you follow the guidelines?


Description

Since I enjoy using both the Miniflux and LinkAce services, I wanted to integrate the two.
This pull request adds the LinkAce integration (already asked in #1916).

Changes

  • Added integration with LinkAce service.
  • Tested the changes, and everything seems to work fine.

Details

  • The LinkAce API documentation is available here.
  • This integration allows Miniflux to interact with LinkAce, providing seamless connectivity between the two services.

@fguillot
Copy link
Member

There are few issues in the unit tests and linter checks. Looks good other than that.

@fguillot fguillot linked an issue Jan 24, 2024 that may be closed by this pull request
1 task
@MDeLuise
Copy link
Contributor Author

MDeLuise commented Jan 24, 2024

Thanks for the quick feedback. I've addressed the issues raised during the review:

  • Unit Tests: I have added the missing label translations that were required by the unit tests.
  • Linter: The linter was indicating some formatting changes needed in the created file. I've made the necessary adjustments to ensure compliance.

The changes should now meet the requirements. Please let me know if any further modifications are necessary.

Screenshot 2024-01-24 at 08 25 11 Screenshot 2024-01-24 at 08 22 52

@fguillot fguillot merged commit 1e70446 into miniflux:main Jan 26, 2024
15 checks passed
@MDeLuise MDeLuise deleted the feature-linkace branch January 26, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Save to LinkAce
2 participants