Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Change button and link role #2334

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

krvpb024
Copy link

@krvpb024 krvpb024 commented Feb 5, 2024

Do you follow the guidelines?

Made this change according to WAI-ARIA link role.

An interactive reference to an internal or external resource that, when activated, causes the user agent to navigate to that resource.
...
If pressing the link triggers an action but does not change browser focus or page location, authors are advised to consider using the button role instead of the link role.

@krvpb024 krvpb024 changed the title Button and link Change button and link role Feb 5, 2024
@krvpb024 krvpb024 changed the title Change button and link role a11y: Change button and link role Feb 5, 2024
@fguillot fguillot merged commit 4f57309 into miniflux:main Feb 6, 2024
15 checks passed
@krvpb024 krvpb024 deleted the button_and_link branch February 6, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants