a11y: Add alert role to alert message element #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you follow the guidelines?
Current alert message element without alert role won't be announced by screen readers unless screen reader users navigate on it.
For example: in login page, if a user type the wrong username or password, the user will be redirected to the same page and the alert message "Invalid username or password." shows. But the screen reader will only announce the login page is loaded and is focus on username input (because of the autofocus attribute.) The user won't know why they get back to the login page instead of the home page.
But if the alert message element has set the alert role, the screen reader will announce the message once the page loaded. The user can understand the situation better.