Resize favicons before storing them #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to avoid resizing the image if the size is already 16x16? Optionally, adding a unit test would be nice. |
jvoisin
force-pushed
the
resize_icons
branch
2 times, most recently
from
512ccb5 to
a295840
Compare
|
Tests and checks added :) |
jvoisin
force-pushed
the
resize_icons
branch
2 times, most recently
from
f0a00aa to
7fb50f1
Compare
fguillot
reviewed
Dec 16, 2024
Some websites are using images of O(10kB) when not )O(100kB) for their favicons. As miniflux only displays them with a 16x16 resolution, let's do our best to resize them before storing them in the database. This should make miniflux consume less bandwidth when serving pages, for the joy of mobile users on a small data plan. Of course, images that already are 16x16 aren't resized.
jvoisin
force-pushed
the
resize_icons
branch
from
953fc76 to
7760711
Compare
|
I haven't had a chance to actually test this yet, but do you know how this interacts with scaling? For example, Miniflux's 16x16 favicons are actually displayed using 32x32 device pixels on my desktop with 2x scaling. I'm assuming that resizing them down to 16x16 will make them (more) blurry. Maybe using 32x32 or even 48x48 might be a safer option. |
|
Oh, good point! 32x32 sounds good to me, why 48x48? Are there really people downscaling resolution 3 times? |
jvoisin
added a commit
to jvoisin/v2
that referenced
this pull request
Dec 16, 2024
As suggested by @michaelkuhn in miniflux#2998 (comment)
fguillot
pushed a commit
that referenced
this pull request
Dec 17, 2024
As suggested by @michaelkuhn in #2998 (comment)
WShihan
pushed a commit
to WShihan/miniflux
that referenced
this pull request
Feb 23, 2025
As suggested by @michaelkuhn in miniflux#2998 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some websites are using images of O(10kB) when not O(100kB) for their favicons. As miniflux only displays them with a 16x16 resolution, let's do our best to resize them before storing them in the database. This should make miniflux consume less bandwidth when serving pages, for the joy of mobile users on a small data plan.