fix: Inbox処理でLD-Signature検証中のエラーが不要にリトライされる問題を修正#17615
Open
fruitriin wants to merge 1 commit into
Open
Conversation
verifyRsaSignature2017 が jsonld.ValidationError 等の非 JsonLdError を 投げた場合、UnrecoverableError に包まれずそのまま再スローされていたため、 Bull が無駄にリトライし error レベルでスタックトレースが出力されていた。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17615 +/- ##
===========================================
+ Coverage 15.14% 24.95% +9.81%
===========================================
Files 248 1161 +913
Lines 12416 39681 +27265
Branches 4214 11056 +6842
===========================================
+ Hits 1880 9902 +8022
- Misses 8245 23857 +15612
- Partials 2291 5922 +3631 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
このPRによるapi.jsonの差分 |
Contributor
Backend Memory Usage ReportAfter GC
V8 Heap Snapshot Statistics
Runtime Loaded JS FootprintClick to show
Largest Newly Loaded Modules
|
Member
|
これと関係ある?(無さそう) #17613 |
Contributor
Author
ドラフトになってるのは動作確認が未完了だからなので(これから手元環境に投入する予定ではある) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
InboxでJSONLD 検証中に、シグネチャ検証以外のエラーが起きた場合、UnrecoverableError に包む
Why
verifyRsaSignature2017 が jsonld.ValidationError 等の非 JsonLdError を 投げた場合、UnrecoverableError に包まれずそのまま再スローされていたため、
Bull が無駄にリトライし error レベルでスタックトレースが出力されていた。
Additional info (optional)
Checklist