Skip to content

fix: Inbox処理でLD-Signature検証中のエラーが不要にリトライされる問題を修正#17615

Open
fruitriin wants to merge 1 commit into
misskey-dev:developfrom
fruitriin:fix/inbox-jsonld-unrecoverable
Open

fix: Inbox処理でLD-Signature検証中のエラーが不要にリトライされる問題を修正#17615
fruitriin wants to merge 1 commit into
misskey-dev:developfrom
fruitriin:fix/inbox-jsonld-unrecoverable

Conversation

@fruitriin

Copy link
Copy Markdown
Contributor

What

InboxでJSONLD 検証中に、シグネチャ検証以外のエラーが起きた場合、UnrecoverableError に包む

Why

verifyRsaSignature2017 が jsonld.ValidationError 等の非 JsonLdError を 投げた場合、UnrecoverableError に包まれずそのまま再スローされていたため、
Bull が無駄にリトライし error レベルでスタックトレースが出力されていた。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

verifyRsaSignature2017 が jsonld.ValidationError 等の非 JsonLdError を
投げた場合、UnrecoverableError に包まれずそのまま再スローされていたため、
Bull が無駄にリトライし error レベルでスタックトレースが出力されていた。

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.95%. Comparing base (1173550) to head (e343edc).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...kend/src/queue/processors/InboxProcessorService.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17615      +/-   ##
===========================================
+ Coverage    15.14%   24.95%   +9.81%     
===========================================
  Files          248     1161     +913     
  Lines        12416    39681   +27265     
  Branches      4214    11056    +6842     
===========================================
+ Hits          1880     9902    +8022     
- Misses        8245    23857   +15612     
- Partials      2291     5922    +3631     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions

Copy link
Copy Markdown
Contributor

Backend Memory Usage Report

After GC

Metric Base Head Δ median Δ MAD Δ min Δ max
HeapUsed 89.3 MB
± 0 MB
89.3 MB
± 0 MB
$\color{orange}{\text{+0 MB}}$
$\color{orange}{\text{+0\%}}$
0 MB $\color{green}{\text{-0 MB}}$ $\color{orange}{\text{+0 MB}}$
Pss 284.5 MB
± 2.1 MB
284.8 MB
± 1.8 MB
$\color{orange}{\text{+0.2 MB}}$
$\color{orange}{\text{+0.1\%}}$
3.4 MB $\color{green}{\text{-4 MB}}$ $\color{orange}{\text{+5.4 MB}}$
Private_Dirty 221.7 MB
± 2.3 MB
222.1 MB
± 1.4 MB
$\color{orange}{\text{+0.3 MB}}$
$\color{orange}{\text{+0.1\%}}$
3.7 MB $\color{green}{\text{-3.9 MB}}$ $\color{orange}{\text{+4.9 MB}}$
VmRSS 316.7 MB
± 2.2 MB
316.9 MB
± 1.8 MB
$\color{orange}{\text{+0.2 MB}}$
$\color{orange}{\text{+0.1\%}}$
3.3 MB $\color{green}{\text{-4.1 MB}}$ $\color{orange}{\text{+5.5 MB}}$
External 3.8 MB
± 0 MB
3.8 MB
± 0 MB
0 MB
0%
0 MB 0 MB $\color{orange}{\text{+0 MB}}$

V8 Heap Snapshot Statistics

Metric Base Head Δ median Δ MAD Δ min Δ max
Total 90.3 MiB
± 3.9 KiB
90.3 MiB
± 2.2 KiB
$\color{orange}{\text{+12.2 KiB}}$
$\color{orange}{\text{+0\%}}$
13.8 KiB $\color{green}{\text{-3.3 KiB}}$ $\color{orange}{\text{+44.8 KiB}}$
Code
25.1% → 25.1%
22.7 MiB
± 1.6 KiB
22.7 MiB
± 1.5 KiB
$\color{green}{\text{-312 B}}$
$\color{green}{\text{-0\%}}$
2.6 KiB $\color{green}{\text{-3 KiB}}$ $\color{orange}{\text{+43.3 KiB}}$
Strings
38.9% → 38.9%
35.2 MiB
± 848 B
35.2 MiB
± 1.1 KiB
$\color{green}{\text{-176 B}}$
$\color{green}{\text{-0\%}}$
3 KiB $\color{green}{\text{-3.2 KiB}}$ $\color{orange}{\text{+5.3 KiB}}$
JS arrays
13.9% → 13.9%
12.5 MiB
± 0 B
12.5 MiB
± 0 B
$\color{green}{\text{-48 B}}$
$\color{green}{\text{-0\%}}$
0 B $\color{green}{\text{-48 B}}$ $\color{green}{\text{-48 B}}$
Typed arrays
0.5% → 0.5%
477 KiB
± 0 B
477 KiB
± 0 B
0 B
0%
0 B 0 B $\color{orange}{\text{+8.1 KiB}}$
System objects
10.8% → 10.8%
9.7 MiB
± 936 B
9.7 MiB
± 464 B
$\color{orange}{\text{+312 B}}$
$\color{orange}{\text{+0\%}}$
1.3 KiB $\color{green}{\text{-1,016 B}}$ $\color{orange}{\text{+2.9 KiB}}$
Other JS objects
10.7% → 10.7%
9.7 MiB
± 16 B
9.7 MiB
± 0 B
$\color{orange}{\text{+16 B}}$
$\color{orange}{\text{+0\%}}$
16 B $\color{green}{\text{-16 B}}$ $\color{orange}{\text{+64 B}}$
Other non-JS objects
0.1% → 0.1%
114.8 KiB
± 0 B
114.8 KiB
± 0 B
0 B
0%
0 B 0 B 0 B

Runtime Loaded JS Footprint

Click to show
Metric Base Head Δ Δ (%)
Loaded JS modules 136 136 0 0%
Loaded JS source 12.4 MiB 12.4 MiB -13 B -0%
External packages loaded 23 23 0 0%
Native addon packages 1 1 0 0%

Largest Newly Loaded Modules

Module Package Loaded JS
packages/backend/built/ApNoteService-BlTNOUtN.js backend 3.6 MiB
packages/backend/built/ServerService-BoHMHfXO.js backend 949.8 KiB
packages/backend/built/endpoints-CIh3i-26.js backend 850.9 KiB
packages/backend/built/MetaEntityService-u-nWtQ5J.js backend 612 KiB
packages/backend/built/gen-spec-D3DhTT8S.js backend 55.7 KiB
packages/backend/built/GlobalModule-B7vXKPoJ.js backend 51.2 KiB

See workflow logs for details

@KisaragiEffective KisaragiEffective added the 🌌Federation The Federation/ActivityPub feature label Jun 24, 2026
@kakkokari-gtyih

Copy link
Copy Markdown
Member

これと関係ある?(無さそう) #17613

@fruitriin

Copy link
Copy Markdown
Contributor Author

これと関係ある?(無さそう) #17613
エラー扱いになったときの扱いしか変更してないから 関係なさそう

ドラフトになってるのは動作確認が未完了だからなので(これから手元環境に投入する予定ではある)
コード自体は問題なさそうならOpenにしてもよいです

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review June 24, 2026 12:53
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌌Federation The Federation/ActivityPub feature packages/backend Server side specific issue/PR size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants