feat: expose secp hashing to lua environment #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Maurer <[email protected]>
Signed-off-by: nicol-ii <[email protected]>
Signed-off-by: nicol-ii <[email protected]>
|
This is great! @nicol-ii if you can fix up the linter errors then we should be able to push this forward some |
HalosGhost
requested changes
Feb 26, 2025
Comment on lines
+46
to
+50
|
|
||
| hash = make_hash("Hello World!") | ||
| print(hash) | ||
|
|
||
| if sequence < from_seq then |
There was a problem hiding this comment.
Presumably, this is meant to test that the newly-exposed function works; can this be verified using a real test instead of adding IO to the bytecode generation?
On that note, when testing the exposure of a hash-function (or any data-transformation) specifically, it's probably a good idea to verify that it works against known values (i.e., I'd suggest asserting that the hash from "Hello World!" is what you expect).
Comment on lines
+318
to
+322
| auto unsigned_str = std::vector<unsigned char>(sz); | ||
| std::memcpy(unsigned_str.data(), str, sz); | ||
| sha.Write(unsigned_str.data(), sz); | ||
| cbdc::hash_t computed_hash{}; | ||
| sha.Finalize(computed_hash.data()); |
There was a problem hiding this comment.
cbdc::hash_data() is effectively this snippet refactored into a method; I might suggest using it here directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: expose secp hashing to lua environment
Exposes a hash function to the Lua smart contract execution environment.
Additionally adds a handful of library version bumps and other cleanup.