process: call waitpid for kqueue to match pidfd behavior (#138)

mitchellh · Jan 24, 2025 · 31eed4e · 31eed4e
2 parents aceef3d + b138093
commit 31eed4e
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/watcher/process.zig b/src/watcher/process.zig
@@ -189,6 +189,14 @@ fn ProcessKqueue(comptime xev: type) type {
                         c_inner: *xev.Completion,
                         r: xev.Result,
                     ) xev.CallbackAction {
+                        // Reap the process. We do this because our xev.Process
+                        // docs note that this is the equivalent of calling
+                        // `wait` on a process. The Linux side (pidfd) does this
+                        // automatically since the `waitid` syscall is used.
+                        if (r.proc) |_| {
+                            _ = posix.waitpid(c_inner.op.proc.pid, 0);
+                        } else |_| {}
+
                         return @call(.always_inline, cb, .{
                             common.userdataValue(Userdata, ud),
                             l_inner,