Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group ckeditor packages #15

Merged
merged 1 commit into from
Apr 30, 2024
Merged

group ckeditor packages #15

merged 1 commit into from
Apr 30, 2024

Conversation

ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Apr 26, 2024

What are the relevant tickets?

Description (What does it do?)

This PR tells renovate to group CKeditor5 packages.

Since that seems to be working and we use CKeditor elsewhere (e.g., OCW Studio) I think it's worth adding this here. In general, renovate is useless on CKEditor unless the updates are grouped—The various packages generally need to have the same version.

How can this be tested?

  1. Observe that this worked in MIT: Open Update ckeditor monorepo to v41 (major) mit-learn#795

@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Apr 26, 2024
@feoh feoh self-requested a review April 29, 2024 13:25
@ChristopherChudzicki ChristopherChudzicki merged commit e0b35f1 into main Apr 30, 2024
1 check passed
@ChristopherChudzicki ChristopherChudzicki deleted the cc/group-ckeditor branch April 30, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants