Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.11 → v0.15.12](astral-sh/ruff-pre-commit@v0.15.11...v0.15.12) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… tests (#3026) * Update Playwright image; fix image tag for Apple Silicon; ignore v3 offline tests * Update settings variable to PLAYWRIGHT_IMAGE_ARCH * Update wording in README
* Remove Lecture Videos LRT from non-video resources * Flag updated websites as needing republishing * Make migration self-contained
There was a problem hiding this comment.
Code Review
This pull request updates the project to version 0.184.5 and includes several dependency upgrades, such as Sentry, Stylelint, and PyGithub. It adds configuration support for Apple Silicon in end-to-end tests via a new PLAYWRIGHT_IMAGE_ARCH setting and introduces a data migration to remove the 'Lecture Videos' resource type from non-video content. Feedback was provided regarding a potential type mismatch in the new migration where filtering by uuid using primary key values could lead to errors.
|
|
||
| WebsiteContent.objects.bulk_update(resources, ["metadata"]) | ||
| Website.objects.filter( | ||
| uuid__in={r.website_id for r in resources} |
There was a problem hiding this comment.
The Website model in this project typically uses an integer id as its primary key, while uuid is a separate field. Since r.website_id refers to the primary key of the related website, filtering by uuid__in will likely fail or result in a DataError in PostgreSQL due to type mismatch. You should filter by id__in or pk__in instead.
| uuid__in={r.website_id for r in resources} | |
| id__in={r.website_id for r in resources} |
pt2302
renovate[bot]
pre-commit-ci[bot]