-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python and django #4019
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
6852801 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[staff_user-200].json | View secret |
6852801 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[staff_user-200].json | View secret |
6852801 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[staff_user-200].json | View secret |
6852801 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[staff_user-200].json | View secret |
6852802 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[staff_user-200].json | View secret |
6852802 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[staff_user-200].json | View secret |
6852803 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[user-404].json | View secret |
6852803 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[user-404].json | View secret |
6852804 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[user-404].json | View secret |
6852804 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[user-404].json | View secret |
6852804 | Bearer Token | 67048f3 | cassettes/channels.views.posts_test.test_get_removed_post[user-404].json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
30979ae
to
b1acbb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Everything i tested worked great
Note for future reference: I did not upgrade django beyond 4.1.x because django 4.2+ requires PostgreSQL 12+ |
Additional notes:
|
Pre-Flight checklist
What are the relevant tickets?
Closes #3724
What's this PR do?
How should this be manually tested?
Basically test everything. In particular:
registration, login, logout, forgot password
hijacking users
make posts and comments
backpopulate course data (edx or ocw or xpro, pick whatever you like).
search
micromasters/open-discussions integration is a bit tricky to test locally, I was planning to leave this for RC.
Any background context you want to provide?
moto
version update doubled the python unit test time, but then I realized a few global fixtures that usemoto
were being unnecessarily called for every test viaautouse=true
. Fixing that dropped total python test time to normal.django-hijack
version update required a new template file, removal ofdjango-hijack-admin
, and some changes to how a hijacked user is detected. The UI that indicates you are logged in as a hijacked user looks different now.What GIF best describes this PR or how it makes you feel?