close pipes after use (redundant but just in case)

also fix typo in example
mittwald · Feb 13, 2025 · 4833944 · 4833944
1 parent 598385b
commit 4833944
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/examples/timestamps.d/timestamps.hcl b/examples/timestamps.d/timestamps.hcl
@@ -6,6 +6,6 @@ job "echoloop" {
   ]
 
   stdout = "test.log"
-  stdout = "test_error.log"
+  stderr = "test_error.log"
   enableTimestamps = true
 }
diff --git a/pkg/proc/basejob.go b/pkg/proc/basejob.go
@@ -121,11 +121,13 @@ func (job *baseJob) startOnce(ctx context.Context, process chan<- *os.Process) e
 		if err != nil {
 			return fmt.Errorf("failed to create stdout pipe for process: %s", err.Error())
 		}
+		defer stdoutPipe.Close()
 
-		stderrPipe, _ := cmd.StderrPipe()
+		stderrPipe, err := cmd.StderrPipe()
 		if err != nil {
 			return fmt.Errorf("failed to create stderr pipe for process: %s", err.Error())
 		}
+		defer stderrPipe.Close()
 
 		go job.logWithTimestamp(stdoutPipe, job.stdout)
 		go job.logWithTimestamp(stderrPipe, job.stderr)