bugfix(mjml-browser): not building #3025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added externals for node.js only code, not required for browser - mocks for htmlnano and mjml-migrate - added globalObject - updated gitignore for testing files
- added html-minifier-terser (exc. terser) and associated dependencies - created aliases for htmlnano and terser - created minify.js file to process minification - removed alias for mjml-migrate
guigui64
reviewed
Dec 19, 2025
- updated webpack configuration - removed unused mjml-migrate browser mock
guigui64
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Updated
mjml-browserpackage to build and work on the mjml5 branchWhy:
Package failed build
How: