Skip to content

Fix/inventory highlights#85

Merged
mkram17 merged 5 commits intov1.0.0from
fix/inventory-highlights
Mar 21, 2026
Merged

Fix/inventory highlights#85
mkram17 merged 5 commits intov1.0.0from
fix/inventory-highlights

Conversation

@0xar-ds
Copy link
Collaborator

@0xar-ds 0xar-ds commented Mar 9, 2026

depends on #90

  • Dropped SlotHighlightCache
    • There was no API in common nor the cache was shared; theres now a SlotHighlight interface which enforces the texture as well the resolved argb retrieval API.
      • We should consider whether we come with a @RegisterWidget-alike annotation for slot highlights, in that of their registration/hooking be automatic as well.
  • Fixed to-sell data failing due to ChestLoadedEvent resolving whilst Hypixel was yet to populate the in-lore information
  • Fixed highlights drawing off mouse position ([v1.0.0] Inventory Highlights misrendering #79)
  • We should consider a different highlight background PNG; on a white-like texture pack, the color it taints is barely distinguishable, for the color map of the current texture is barely visible.

@0xar-ds 0xar-ds mentioned this pull request Mar 9, 2026
@mkram17
Copy link
Owner

mkram17 commented Mar 15, 2026

@0xar-ds will these issues be fixed in pr 86? If possible can you fix these before merging or merge 86 at the same time?

 C:\mc modding\Bazaar-Utils-Modern\src\main\java\com\github\mkram17\bazaarutils\features\gui\inventory\restrictsell\InstantSellRestrictions.java:14: error: cannot find symbol
import com.github.mkram17.bazaarutils.utils.InstaSellUtil;
                                           ^
  symbol:   class InstaSellUtil
  location: package com.github.mkram17.bazaarutils.utils
 C:\mc modding\Bazaar-Utils-Modern\src\main\java\com\github\mkram17\bazaarutils\utils\bazaar\RestrictionHelper.java:31: error: cannot find symbol
    protected abstract List<RestrictionControl<?>> getRestrictors();
                            ^
  symbol:   class RestrictionControl
  location: class RestrictionHelper<T>
  where T is a type-variable:
    T extends RestrictionState declared in class RestrictionHelper

@0xar-ds
Copy link
Collaborator Author

0xar-ds commented Mar 15, 2026

@0xar-ds will these issues be fixed in pr 86? If possible can you fix these before merging or merge 86 at the same time?

Yes, they'd be fixed, but imo just hold these two until ResourcefulConfig launches a release, we merge that update first & I'll rebase #86 to consume lists. Should be today.
image

@0xar-ds
Copy link
Collaborator Author

0xar-ds commented Mar 18, 2026

Rebasing to #90

@0xar-ds 0xar-ds force-pushed the fix/inventory-highlights branch from df51b8e to 8f941b1 Compare March 18, 2026 19:00
0xar-ds added 5 commits March 21, 2026 15:15
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Each SlotHighlight is now to own its cache (there was no shared
computation nor shared api; to have a central cache was an abstraction
which leveraged to nothing) and apply a simple interface which we could
further elevate to require a annotated method, in that of to
automatically handle this type of highlights on our mixin.

Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
@0xar-ds 0xar-ds force-pushed the fix/inventory-highlights branch from 8f941b1 to 2a866b4 Compare March 21, 2026 18:20
@0xar-ds
Copy link
Collaborator Author

0xar-ds commented Mar 21, 2026

@mkram17 Any chances you could merge both this and #86? I can not as build failing is blocking this one

@mkram17 mkram17 merged commit 6063e44 into v1.0.0 Mar 21, 2026
3 of 5 checks passed
@mkram17 mkram17 deleted the fix/inventory-highlights branch March 21, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants