Conversation
Merged
mkram17
reviewed
Mar 12, 2026
src/main/java/com/github/mkram17/bazaarutils/events/ChestLoadedEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/mkram17/bazaarutils/features/gui/inventory/InstantSellHighlight.java
Show resolved
Hide resolved
src/main/java/com/github/mkram17/bazaarutils/events/ChestLoadedEvent.java
Outdated
Show resolved
Hide resolved
mkram17
approved these changes
Mar 15, 2026
Owner
|
@0xar-ds will these issues be fixed in pr 86? If possible can you fix these before merging or merge 86 at the same time? |
Collaborator
Author
Collaborator
Author
|
Rebasing to #90 |
df51b8e to
8f941b1
Compare
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Each SlotHighlight is now to own its cache (there was no shared computation nor shared api; to have a central cache was an abstraction which leveraged to nothing) and apply a simple interface which we could further elevate to require a annotated method, in that of to automatically handle this type of highlights on our mixin. Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
Signed-off-by: 0xar-ds <sadden-rope-sleek@duck.com>
8f941b1 to
2a866b4
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

depends on #90