Fix listener leak: eliminate transient MarketPrices instantiation and remove BUListener inheritance

[Copilot]

Every call to resolveInput in TransactionAmount and TransactionCost created a new MarketPrices(productId) just to read a price once. Since MarketPrices extends BUListener, each instance permanently self-registers in ListenerManager.listeners and subscribes to the event bus — with no unsubscribe path — leaking on every sign interaction.

Changes

• MarketPrices: Added static getPriceForPosition(String productId, PricingPosition, OrderType) that queries BazaarDataManager directly and applies the same ±0.1 offset. The instance overload now delegates to this static method instead of duplicating the switch logic. With no event handling remaining, the class no longer extends BUListener — removing the cache fields (buyPriceInfo, sellPriceInfo), the @EventHandler, the private updateMarketPrices(String) helper, and the subscribe() call. MarketPrices is now a plain value class with no listener registration:

// Before — leaks a BUListener on every resolveInput call
MarketPrices marketPrices = new MarketPrices(state.productId);
return new ResolvedInput.Value(marketPrices.getPriceForPosition(getPricingPosition(), getOrderType()));

// After — no instance needed; static call reads fresh from BazaarDataManager
return new ResolvedInput.Value(MarketPrices.getPriceForPosition(state.productId(), getPricingPosition(), getOrderType()));

• SignInputHelper: Removed transient new MarketPrices(...) from both TransactionAmount.resolveInput and TransactionCost.resolveInput; dropped the now-dead MarketPrices parameter from computeFixedValue and computeMaxValue.
• InstantBuyAmountHelper, BuyOrderAmountHelper, SellOfferAmountHelper: Updated computeFixedValue signatures to match; removed unused MarketPrices import.

---

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• piston-meta.mojang.com
  • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[mkram17]

@copilot make this method use the static one

[Copilot]

Done in commit df5bc60. The instance method now delegates to the static overload. With no event handler remaining, I also removed the dead buyPriceInfo/sellPriceInfo fields, the updateMarketPrices(String) private helper, the @EventHandler, extends BUListener, and the subscribe() call — so MarketPrices is now a plain value class with no listener registration at all.