Skip to content

proxmox profile/role - #1006

Open
rrotter wants to merge 3 commits into
productionfrom
proxmox
Open

proxmox profile/role#1006
rrotter wants to merge 3 commits into
productionfrom
proxmox

Conversation

@rrotter

@rrotter rrotter commented May 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@rrotter
rrotter force-pushed the proxmox branch 2 times, most recently from 30bdcdd to aee628e Compare June 5, 2026 13:43
@rrotter
rrotter marked this pull request as ready for review August 14, 2026 14:18
@rrotter
rrotter requested a balanced review from Copilot August 14, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Proxmox host role and its external Puppet module dependency.

Changes:

  • Adds the Proxmox role and supporting fixture dependency.
  • Fixes Git repository fixture generation.
  • Removes the universal minimum-role assertion.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
manifests/role/proxmox.pp Defines the Proxmox role.
rakelib/metadata.yaml Registers the Proxmox dependency.
.fixtures.yml Adds the Proxmox test fixture.
rakelib/forge.rake Corrects repository fixture initialization.
spec/classes/all_roles.rb Removes the minimum-role expectation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread spec/classes/all_roles.rb
Comment thread rakelib/metadata.yaml Outdated
Comment thread manifests/role/proxmox.pp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants