profile::base: rm dbus - #1034
Merged
Merged
Conversation
skorner
approved these changes
Aug 3, 2026
skorner
left a comment
skorner
left a comment
Member
There was a problem hiding this comment.
Given dbus is part of the default install, it seems quite helpful to remove this confusing line!
daaang
approved these changes
Aug 3, 2026
daaang
left a comment
daaang
left a comment
Collaborator
There was a problem hiding this comment.
My best guess from what I remember doing at the time is that I was probably copying something I found in an abandoned ansible playbook. Certainly, if you find yourself wondering why something was added in a commit that starts with aaaa, there’s a very high chance the answer is “unthinking copy/paste from something Matt found on mimosa during his first few months here.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why we ever cared whether
dbuswas installed, but it's part of the default Debian install, so whatever the original reason, this line effectively a no-op.Note:
dbuspackage was added in aaaacd2, part of #1.