Rethink etcd db alerts - #1036
Merged
Merged
Conversation
The previous alerts' 30 minute window was, in this case, way too long to be effective. It takes about 30 minutes in practice to go from "everything is perfectly fine" to "it's full and everything stopped responding to all requests." Given the short window, it also seems silly to bother with deltas. It should never ever be more than 25% full let alone 50% full, so that should be good enough.
botimer
approved these changes
Aug 3, 2026
botimer
left a comment
botimer
left a comment
Member
There was a problem hiding this comment.
Agreed that, while we prefer the delta style in general, etcd db size is a bit different than general disk trend in terms of expectation and intervention.
| expr: > | ||
| max by (datacenter) (delta(etcd_debugging_mvcc_db_total_size_in_bytes[5m])) > 10000 | ||
| for: "30m" | ||
| max by (datacenter) (etcd_mvcc_db_total_size_in_bytes) > 2 ^ 30 |
Member
There was a problem hiding this comment.
I like that the summary includes the more familiar value of 1Gi, though I don't find the 2 ^ 30 form particularly scannable. Should we consider 1 * 1024 * 1024 * 1024 or 1 * 1024^3?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous alerts' 30 minute window was, in this case, way too long to be effective. It takes about 30 minutes in practice to go from "everything is perfectly fine" to "it's full and everything stopped responding to all requests."
Given the short window, it also seems silly to bother with deltas. It should never ever be more than 25% full let alone 50% full, so that should be good enough.