image VMs without fileserver - #1046
Merged
Merged
Conversation
US/Eastern works on bookworm, but America/Detroit works on every version. Remove a needless difference between bookworm and trixie preseeds.
rrotter
force-pushed
the
image_without_fileserver
branch
3 times, most recently
from
August 19, 2026 01:31
085e4cc to
37d94de
Compare
- generate puppet.conf, rather than downloading from fileserver
- remove packages from preseed:
- dirmngr: not needed, probably leftover from adding puppetlabs deb
- openssh-server: installed on first puppet run
- iptables-persistent
- installed on first puppet run
- not needed w/o ssh
- removing this removes the need to download iptables config
- qemu-guest-agent: install from main pkgset, not late_command
rrotter
force-pushed
the
image_without_fileserver
branch
from
August 19, 2026 01:47
37d94de to
fbe8ebb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Debian VM preseed templates and Puppet module parameters to remove dependency on an external “fileserver” during image installs, primarily by generating puppet.conf locally and eliminating preseed-time firewall/package downloads.
Changes:
- Replace fileserver-based
wgetdownloads with generated/etc/puppetlabs/puppet/puppet.confusing a newpuppetserverparameter. - Remove
ssh-server,iptables-persistent, anddirmngrfrom preseed package selection; installqemu-guest-agentvia the main package set. - Update module parameters, Hiera fixtures, and specs from
filehosttopuppetserver, and add assertions to prevent fileserver/iptables usage in preseeds.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/virtual_machine/trixie.cfg.erb | Removes fileserver downloads and iptables-related preseed steps; generates puppet.conf and adjusts package selection. |
| templates/virtual_machine/bookworm.cfg.erb | Same as trixie template updates; also adjusts timezone setting in the preseed. |
| manifests/virtual_machine.pp | Replaces filehost parameter documentation/default with puppetserver. |
| manifests/profile/vmhost/host.pp | Wires puppetserver through the vmhost profile into nebula::virtual_machine. |
| spec/fixtures/hiera/default.yaml | Updates fixture data key from filehost to puppetserver. |
| spec/defines/virtual_machine_spec.rb | Updates/extends preseed content expectations to validate new behavior and absence of fileserver/iptables usage. |
| spec/classes/profile/vmhost/host_spec.rb | Updates expectations to use puppetserver parameter instead of filehost. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Looks reasonable to me. |
Member
Author
|
merged corresponding control repo branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Debian preseed files to eliminate fileserver dependency:
puppetserverparameter sets puppet server addressAlso, for consistency, change the time zone in bookworm preseed to match trixie.