Remove unused manifests #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obtained by comparing puppet db with nebula
skorner
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
This looks pretty great and thorough to me. I left one question.
I don't see anything not in use that we want to keep that hasn't already been addressed.
Your solution for maintaining the apache class definition seems reasonable. Although the comments in that new profile should probably be adjusted to reflect why it exists.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the list of unused manifests by comparing a puppet-db query for roles and profiles in use with a list of roles and profiles in Nebula. I've deliberately kept
log_hostandfulcrum::nginxbecauselog_hostis in use on brandy and we will wantfulcrum::nginxlater.Noah let me know that
named_instancescould also go, since we aren't using it for anything new and removing the definitions won't affect anything currently deployed. I did end up keeping part ofnamed_instances::apacheforstandalone_app_host, which only needed the class definition (according to the tests....) so perhaps that could be done another way.