move shib require to top location block #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorner
requested changes
Feb 13, 2024
Comment on lines
-159
to
-160
| AuthType shibboleth | ||
| ShibRequestSetting requireSession 0 |
There was a problem hiding this comment.
These two lines need to be present in the rendered Location / definition (see the diff I posted in slack). You can do this with an auth_require and custom fragment line, as is done here (ignore the auth_require in that example as that is already covered with the require all definition in this manifest). You can probably make this addition to authz_base_requires.
There was a problem hiding this comment.
auth_require or auth_type... I may have pushed my last commit the opposite. But i'll let you correct me if i'm reading this wrong.
There was a problem hiding this comment.
Looks good to me! Go ahead and squash to 1 commit and merge after the tests pass from the squash.
skorner
approved these changes
Feb 14, 2024
add two shib lines remove whitespace
umjnega
force-pushed
the
fulcrum_badrobo_enable
branch
from
6cb2b4a to
d8f9ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went ahead and looked into the fulcrum issue from yesterday and I think I correclty updated the change @skorner made.