Move global shib settings out of the require block #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume the order doesn't matter... Everything looks to be working on the staging servers. In the manual prod config, authtype and shitrequestsetting were before the REquireALL? <Location "/"> |
|
That's correct that whether those two lines are before or after the RequireAll block doesn't affect the outcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first pass at restoring "badrobots" functionality inadvertently had the global settings to enable shib passively for the Fuclrum vhost within the config for a require block. This resulted in these settings being ignored and not applied. The changes in this PR address that issue.