Conversation
qinsoon
requested changes
Dec 22, 2023
Member
There was a problem hiding this comment.
We probably want to put this doc in a separate folder under docs. This doc is not only for the team, but also for any developers. We could have a folder docs/contribute, and put the doc in the folder.
A check list before this PR is merged:
- An issue template for MEP
- An issue template for normal issues (optional)
- Issue tags
MEPandF-request-for-MEP.
docs/team/mep.md
Outdated
| public API changes usually indicate such risks, but these are only indicators, not criteria. The | ||
| assessment of risks is subjective, and we need to discuss in order to reach consensus. | ||
|
|
||
| Note: JEP is also required for things that "require two or more weeks of engineering effort" and/or |
Member
There was a problem hiding this comment.
I would suggest not mentioning too much about JEP, especially when it is irrelevant. 1. As you said, MEP is clearly different from JEP. 2. Not many people are that familiar with JEP so it is hard for them to draw connection between the two.
Collaborator
Author
There was a problem hiding this comment.
I agree. I removed all places that mention JEP, keeping only one sentence that mentions that MEP is inspired by JEP.
This was referenced Jan 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a document that describes the MMTk Enhancement Proposal (MEP).