Added fillTheParentElement feature and added responsive sizes about issue #27 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Is everything okey? Should I change anything? |
mnahkies
requested changes
Feb 17, 2022
There was a problem hiding this comment.
Thanks for the PR @mustafapsd - I can understand the motivation behind it, but I'm not completely comfortable with the current implementation, and wonder if it would make more sense to be a wrapper component around <qr-code> that controlled the size property
Specifically the need to have refreshing properties gives me the most concern. I've left some comments going into more detail - let me know what you think
|
I changed the logic. Users can manage the size from css. To be honest, I've liked this way. |
|
@mnahkies hi, is there any progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've used your package in my several projects, thank you! I added two features. It is shown in this video.
#27
Video