Fix provider metadata when duplicating agents#1917
Open
suainam wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix agent duplication failing when copied provider rows hit self-hosted PostgreSQL schemas that require non-null
user_providers.label.This change preserves
labelandprioritywhen duplicatingUserProviderrows.Why
AgentDuplicationServicecopied provider rows withoutlabel, which caused inserts to fail with a database error on schemas whereuser_providers.labelisNOT NULL.Testing
Notes
Backend e2e tests were not completed in this environment because the local test database was unavailable from the test runner.
Summary by cubic
Fix agent duplication by preserving provider
labelandprioritywhen copyingUserProviderrows. This prevents insert failures on self-hosted PostgreSQL schemas that require a non-nulluser_providers.label, with regression tests added to ensure the metadata is kept.Written for commit 59bb32e. Summary will update on new commits.