Skip to content

Impose a limit of 4k on HTTP headers and request lines #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Impose a limit of 4k on HTTP headers and request lines #379

wants to merge 3 commits into from

Conversation

@djs55
Copy link
Collaborator

@djs55 djs55 commented May 1, 2018

In case someone pipes large amounts of binary junk through the proxy, we impose a 4k limit on line length. Unfortunately we will send back a miscellaneous 500 server error rather than the correct 413 Entity too large, but this is better than nothing.

akimd
akimd approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@akimd akimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm incompetent to review this, you'll know better :) I saw nothing weird (but have no idea what ASN.1 is doing here...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akimd akimd akimd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djs55 @akimd