Fix eq() matcher NPE with nullable value class and null value#578
Closed
KonaEspresso94 wants to merge 1 commit intomockito:mainfrom
Closed
Fix eq() matcher NPE with nullable value class and null value#578KonaEspresso94 wants to merge 1 commit intomockito:mainfrom
KonaEspresso94 wants to merge 1 commit intomockito:mainfrom
Conversation
Contributor
|
@m-koops FYI the gift that keeps on giving |
Contributor
|
@KonaEspresso94 Thank you very much for raising the NPE issue and providing your fix in this PR. While reviewing the change, I had to make some slight adjustments. Therefore I decided to prepare a new commit/PR (#579). @TimvdLippe can you review that new PR? |
Author
|
@TimvdLippe @m-koops Thanks for your quick feedback. I’ll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request! But first:
./gradlew spotlessApply :tests:spotlessApplyfor auto-formatting.Summary
This PR fixes the NPE issue in
eq()matcher when used with nullable value class and null value.Fixes #577
Problem
After #545 added value class support to
eq(), usingeq(null)with a nullable value class type throwsNullPointerException:Root Cause
In
eqValueClass(), the code accessesvalue::classbefore checking ifvalueis null:Solution
Add a null check at the beginning of
eqValueClass():This follows the existing pattern used in
toKotlinType()inValueClassSupport.kt.Changes
Matchers.kt: Add null check ineqValueClass()MatchersTest.kt: Add test cases for nullable value class with null value