NonZero (new_unchecked) Proof for Contract (Init) #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added contract and placeholder harness
carolynzech
reviewed
Oct 14, 2024
Corrected issues from Pull Request
Restored previous cargo files
carolynzech
approved these changes
Oct 23, 2024
carolynzech
left a comment
carolynzech
left a comment
There was a problem hiding this comment.
LGTM, modulo these suggestions. Can you please also update your PR description? It says that you only have harnesses for i32, but you have new_unchecked harnesses for all the primitive integer types.
zhassan-aws
approved these changes
Oct 26, 2024
Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Zyad Hassan <[email protected]>
carolynzech
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #71 (Safety of NonZero)
We are looking for feedback on our proof_for_contract. We have implemented it for all the data types.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.