Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Improve revenue information #3250

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

IMB11
Copy link
Contributor

@IMB11 IMB11 commented Feb 12, 2025

This pull request improves the revenue information available to the user.

Note: All financial values in this screenshot are mock values and not actually what I earn on Modrinth.

image
image
image

Enhancements to Revenue Display:

Improvements to Legal Information Page:

  • apps/frontend/src/pages/legal/cmp-info.vue: Added an explanation for "Pending In Transit" revenue and a calculator to estimate when revenue becomes available for withdrawal. Included a table displaying Modrinth's revenue transparency information. [1] [2]

Utility Functions:

Plugin Updates:

@IMB11 IMB11 changed the title feat(dashboard): Improve revenue information feat(frontend): Improve revenue information Feb 12, 2025
@IMB11 IMB11 marked this pull request as draft February 12, 2025 17:02
@IMB11 IMB11 marked this pull request as ready for review February 12, 2025 17:05
@Minenash
Copy link
Contributor

Like the general idea and look, though instead of a total pending, and next pending; I think it's only possible to have 3 months with pending amounts at a time. Maybe having the amount of the 3 months (like if it's Nov 15, You have September's Revenue, October's and November's)

Also the "in transit" phrase implies that it is currently in the process of it being sent, when that's not really true

@IMB11
Copy link
Contributor Author

IMB11 commented Feb 13, 2025

Like the general idea and look, though instead of a total pending, and next pending; I think it's only possible to have 3 months with pending amounts at a time. Maybe having the amount of the 3 months (like if it's Nov 15, You have September's Revenue, October's and November's)

Also the "in transit" phrase implies that it is currently in the process of it being sent, when that's not really true

The API doesn't store time information with actual revenue data (analytics doesn't take into account Modrinth's cut/any fees, it's slightly inaccurate by $3-4) - meaning if I did display all the monthly values they'd all be estimates, not really helpful and unnecessary if we already have the accurate total pending value

I think the "in transit" is perfectly acceptable as it is in a way in transit - the ad provider is currently collecting the ad budgets before sending it to Modrinth, it arrives on the date specified. I think this is the only way to keep it understandable for users whilst ensuring that a level of accuracy is kept by showing the total pending as before

@falseresync
Copy link
Contributor

falseresync commented Feb 15, 2025

I think that maybe it'd a good idea to rename "Current Balance" to "Available to withdraw", "Pending in Transit" to "In processing" and "Pending Total" to "Awaits processing"

And then switch places of Pending in Transit and Pending Total

"Awaits processing" (total) could also have a hint at the bottom the same as Pending in Transit does now, saying something along the lines of "earned since Month XX, YYYY".

To be accurate this would probably require subtracting the pending from the total, as far as I can tell

@IMB11
Copy link
Contributor Author

IMB11 commented Feb 16, 2025

I think im going to wait for a proper check from Modrinth before changing terminology, want to get it right without much bikeshedding

@IMB11
Copy link
Contributor Author

IMB11 commented Feb 16, 2025

I think what I have currently is perfectly acceptable honestly

@IMB11
Copy link
Contributor Author

IMB11 commented Feb 19, 2025

@Prospector Just wondering, what is your opinion on the wording - does it need to change?

@Prospector
Copy link
Member

Yeah, definitely should not say "in transit" since that implies something entirely unrelated.

The way I would phrase it is: Available Mar 1 with the date that the funds will become available. However, before implementing this I would want the backend to provide the information rather than pulling from analytics, to ensure accuracy since I would not want to display potentially incorrect information to the user if it was slightly off.

@IMB11
Copy link
Contributor Author

IMB11 commented Feb 19, 2025

Someone else would have to do that - unfortunately my rust knowledge is non-existent

@Prospector
Copy link
Member

yeah, same. that the main reason I haven't overhauled this page yet

@IMB11
Copy link
Contributor Author

IMB11 commented Feb 19, 2025

I would be able to revisit this in a few weeks though, I am in process of learning the language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants