[stdlib] [NFC] Rename List.bytecount() to byte_length()
#3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <[email protected]>
|
I think we might want to make the docstring a bit more elaborate to clarify, for example, that it is not the number of bytes allocated. |
Signed-off-by: martinvuyk <[email protected]>
JoeLoser
approved these changes
Jan 14, 2025
JoeLoser
reviewed
Jan 14, 2025
|
!sync |
modularbot
added
the
imported-internally
Signed-off-by: martinvuyk <[email protected]>
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
Landed in 871045c! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Mar 25, 2025
…` (#54664) [External] [stdlib] [NFC] Rename `List.bytecount()` to `byte_length()` Rename `List.bytecount()` to `byte_length()` to keep consistency with all Stringlike types. Co-authored-by: martinvuyk <[email protected]> Co-authored-by: Joe Loser <[email protected]> Closes #3897 MODULAR_ORIG_COMMIT_REV_ID: bcb5da166f0490eaea10f88a45cf9023e8bb8f63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
List.bytecount()tobyte_length()to keep consistency with all Stringlike types