Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation of messages.yml #122

Open
Marcono1234 opened this issue Oct 18, 2020 · 1 comment
Open

Improve validation of messages.yml #122

Marcono1234 opened this issue Oct 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Marcono1234
Copy link
Contributor

As shown by #121, the validation of the messages.yml file is currently not checking whether projects referenced in quick_links and messages have an entry in project_id.

Note however that mctest is at the moment referenced by messages despite having no quick_links and project_id entry.
@Marcono1234 Marcono1234 added the enhancement New feature or request label Oct 18, 2020
@Marcono1234 Marcono1234 mentioned this issue Oct 18, 2020
Merged
@SPGoding
Copy link
Member

The validation of messages.yml is implemented by 1) converting the YAML file to a JSON file and 2) using JSON schemas to validate the generated JSON file. So I'm not sure if it's possible to do a complicated validation like this 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Marcono1234 @SPGoding