Fix WEB project missing in projects list#121
Merged
Conversation
Member
Yes I guess creating a separate issue would be preferable.
The MCTEST project is used by Arisa in some situations. |
SPGoding
approved these changes
Oct 17, 2020
Contributor
Author
|
Thanks for adding the missing change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117 (probably?)
Despite being referenced by a few messages, the WEB project is currently not part of the project list and therefore also not shown on https://mojira.github.io/helper-messages/.
Maybe it would be good to additionally add a validation step to make sure all projects referenced from
quick_linksandmessageshave an entry underproject_id? (should I create a separate issue for that?)Also note that currently some messages have
mctestas project despite it being neither listed underproject_idnor underquick_links. Should we remove themctestreferences or add the missing entries for it?