Skip to content

Fix WEB project missing in projects list#121

Merged
SPGoding merged 2 commits intomasterfrom
web-project-missing
Oct 19, 2020
Merged

Fix WEB project missing in projects list#121
SPGoding merged 2 commits intomasterfrom
web-project-missing

Conversation

@Marcono1234
Copy link
Contributor

Fixes #117 (probably?)

Despite being referenced by a few messages, the WEB project is currently not part of the project list and therefore also not shown on https://mojira.github.io/helper-messages/.

Maybe it would be good to additionally add a validation step to make sure all projects referenced from quick_links and messages have an entry under project_id? (should I create a separate issue for that?)

Also note that currently some messages have mctest as project despite it being neither listed under project_id nor under quick_links. Should we remove the mctest references or add the missing entries for it?

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2020

CLA assistant check
All committers have signed the CLA.

@Marcono1234 Marcono1234 requested a review from SPGoding October 17, 2020 15:55
@SPGoding
Copy link
Member

SPGoding commented Oct 17, 2020

Maybe it would be good to additionally add a validation step to make sure all projects referenced from quick_links and messages have an entry under project_id? (should I create a separate issue for that?)

Yes I guess creating a separate issue would be preferable.

Should we remove the mctest references or add the missing entries for it?

The MCTEST project is used by Arisa in some situations.

@Marcono1234
Copy link
Contributor Author

Thanks for adding the missing change in index.js! I have created #122 regarding the missing validation.

@SPGoding SPGoding merged commit e7264d5 into master Oct 19, 2020
@SPGoding SPGoding deleted the web-project-missing branch October 19, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete message doesn't link to the project when using it on a web ticket

3 participants