fix verify bug

mojocn · Dec 8, 2023 · 5ab86bd · 5ab86bd
1 parent 88f0921
commit 5ab86bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/store_memory.go b/store_memory.go
@@ -66,6 +66,9 @@ func (s *memoryStore) Set(id string, value string) error {
 }
 
 func (s *memoryStore) Verify(id, answer string, clear bool) bool {
+	if id == "" || answer == "" {
+		return false
+	}
 	v := s.Get(id, clear)
 	return v != "" && v == answer
 }

diff --git a/store_memory_test.go b/store_memory_test.go
@@ -143,6 +143,10 @@ func Test_memoryStore_Verify(t *testing.T) {
 	if got {
 		t.Error("failed3")
 	}
+	got = DefaultMemStore.Verify("saaf", "", true)
+	if got {
+		t.Error("CVE-2023-45292 GO-2023-2386")
+	}
 }
 
 func Test_memoryStore_Get(t *testing.T) {