Merge upstream 'v2.34.5'

mollyim · Dec 10, 2023 · e32c1f3 · e32c1f3
2 parents 4688b4a + a51ed05
commit e32c1f3
Show file tree

Hide file tree

Showing 35 changed files with 944 additions and 102 deletions.
diff --git a/.github/workflows/webrtc_artifacts.yml b/.github/workflows/webrtc_artifacts.yml
@@ -0,0 +1,212 @@
+name: Build WebRTC Artifacts
+run-name: Build WebRTC Artifacts (${{ github.ref_name }})
+
+on:
+  workflow_dispatch:
+    inputs:
+      dry_run:
+        description: "When true, don't upload to GCS"
+        default: false
+        required: false
+        type: boolean
+
+permissions:
+  # Needed to clone the repo
+  contents: 'read'
+  # Needed for google-github-actions/auth.
+  id-token: 'write'
+
+jobs:
+  build_android:
+    name: Build Android
+
+    runs-on: 'ubuntu-latest-8-cores'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install dependencies
+        run: sudo apt-get update && sudo apt-get install -y protobuf-compiler
+
+      - run: ./bin/build-webrtc.py --target android --release
+
+      - name: Output Artifact Checksum
+        run: |
+          sha256sum out/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+
+      - uses: google-github-actions/auth@v1
+        with:
+          workload_identity_provider: 'projects/741367068918/locations/global/workloadIdentityPools/github/providers/github-actions'
+          service_account: '[email protected]'
+
+      - uses: google-github-actions/upload-cloud-storage@v1
+        if: ${{ !inputs.dry_run }}
+        with:
+          path: 'out'
+          destination: build-artifacts.signal.org/libraries
+          glob: 'webrtc-*.tar.bz2'
+          parent: false
+          process_gcloudignore: false
+
+  build_ios:
+    name: Build iOS
+
+    runs-on: 'macos-latest-xl'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - run: brew install protobuf
+
+      # Installs the pkg_resources python module needed to build webrtc on a mac host
+      - run: pip install setuptools
+
+      - run: ./bin/build-webrtc.py --target ios --release
+
+      - name: Output Artifact Checksum
+        run: |
+          sha256sum out/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+
+      - uses: google-github-actions/auth@v1
+        with:
+          workload_identity_provider: 'projects/741367068918/locations/global/workloadIdentityPools/github/providers/github-actions'
+          service_account: '[email protected]'
+
+      - uses: google-github-actions/upload-cloud-storage@v1
+        if: ${{ !inputs.dry_run }}
+        with:
+          path: 'out'
+          destination: build-artifacts.signal.org/libraries
+          glob: 'webrtc-*.tar.bz2'
+          parent: false
+          process_gcloudignore: false
+
+  build_linux:
+    name: Build Linux
+
+    runs-on: 'ubuntu-latest-4-cores'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install dependencies
+        run: sudo apt-get update && sudo apt-get install -y protobuf-compiler crossbuild-essential-arm64
+
+      - run: ./bin/build-webrtc.py --target linux --release
+
+      - name: Output Artifact Checksum
+        run: |
+          sha256sum out/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+          sha256sum out_arm/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+
+      - uses: google-github-actions/auth@v1
+        with:
+          workload_identity_provider: 'projects/741367068918/locations/global/workloadIdentityPools/github/providers/github-actions'
+          service_account: '[email protected]'
+
+      - uses: google-github-actions/upload-cloud-storage@v1
+        if: ${{ !inputs.dry_run }}
+        with:
+          path: 'out'
+          destination: build-artifacts.signal.org/libraries
+          glob: 'webrtc-*.tar.bz2'
+          parent: false
+          process_gcloudignore: false
+
+      - uses: google-github-actions/upload-cloud-storage@v1
+        if: ${{ !inputs.dry_run }}
+        with:
+          path: 'out_arm'
+          destination: build-artifacts.signal.org/libraries
+          glob: 'webrtc-*.tar.bz2'
+          parent: false
+          process_gcloudignore: false
+
+  build_mac:
+    name: Build Mac
+
+    runs-on: 'macos-latest-xl'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - run: brew install protobuf
+
+      # Installs the pkg_resources python module needed to build webrtc on a mac host
+      - run: pip install setuptools
+
+      - run: ./bin/build-webrtc.py --target mac --release
+
+      - name: Output Artifact Checksum
+        run: |
+          sha256sum out/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+          sha256sum out_arm/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+
+      - uses: google-github-actions/auth@v1
+        with:
+          workload_identity_provider: 'projects/741367068918/locations/global/workloadIdentityPools/github/providers/github-actions'
+          service_account: '[email protected]'
+
+      - uses: google-github-actions/upload-cloud-storage@v1
+        if: ${{ !inputs.dry_run }}
+        with:
+          path: 'out'
+          destination: build-artifacts.signal.org/libraries
+          glob: 'webrtc-*.tar.bz2'
+          parent: false
+          process_gcloudignore: false
+
+      - uses: google-github-actions/upload-cloud-storage@v1
+        if: ${{ !inputs.dry_run }}
+        with:
+          path: 'out_arm'
+          destination: build-artifacts.signal.org/libraries
+          glob: 'webrtc-*.tar.bz2'
+          parent: false
+          process_gcloudignore: false
+
+  build_windows:
+    name: Build Windows
+
+    runs-on: 'windows-latest-8-cores'
+
+    steps:
+    - name: Setup git to use linux line endings and keep permissions
+      run: |
+        git config --global core.autocrlf false
+        git config --global core.eol lf
+        git config --global core.filemode false
+
+    - uses: actions/checkout@v3
+
+    - run: python bin/build-webrtc.py --target windows --release
+      shell: bash
+
+    - name: Output Artifact Checksum
+      run: |
+        sha256sum out/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+        sha256sum out_arm/webrtc-*.tar.bz2 | tee -a $GITHUB_STEP_SUMMARY
+      shell: bash
+
+    - uses: google-github-actions/auth@v1
+      with:
+        workload_identity_provider: 'projects/741367068918/locations/global/workloadIdentityPools/github/providers/github-actions'
+        service_account: '[email protected]'
+
+    - uses: google-github-actions/upload-cloud-storage@v1
+      if: ${{ !inputs.dry_run }}
+      with:
+        path: 'out'
+        destination: build-artifacts.signal.org/libraries
+        glob: 'webrtc-*.tar.bz2'
+        parent: false
+        process_gcloudignore: false
+
+    - uses: google-github-actions/upload-cloud-storage@v1
+      if: ${{ !inputs.dry_run }}
+      with:
+        path: 'out_arm'
+        destination: build-artifacts.signal.org/libraries
+        glob: 'webrtc-*.tar.bz2'
+        parent: false
+        process_gcloudignore: false
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,37 @@
 # Changelog
 
+## v2.34.5
+
+- Use unified plan for 1:1 calls
+
+- iOS: Make trivial RemoteDeviceState for IndividualCalls
+
+- iOS: Make isUsingFrontCamera publically readable
+
+- Call Sim: Add deterministic loss handling and lbred test
+
+- Build webrtc using github actions
+
+## v2.34.4
+
+- Fetch build artifacts using a proxy where necessary
+
+- Update to WebRTC m118
+
+## v2.34.3
+
+- Update to webrtc 5845j
+  - Add low bitrate redundancy support
+  - Lower port allocation step delay
+  - Prune TurnPorts on a per-server basis
+  - Unregister sink properly when closing
+
+- Call Sim: Improvements for running large test sets
+
+## v2.34.2
+
+- Group Calls: Propagate demux_id to LocalDeviceState
+
 ## v2.34.1
 
 - Cleanup logging

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/SignalRingRTC.podspec b/SignalRingRTC.podspec
@@ -8,7 +8,7 @@
 
 Pod::Spec.new do |s|
   s.name             = "SignalRingRTC"
-  s.version          = "2.34.1"
+  s.version          = "2.34.5"
   s.summary          = "A Swift & Objective-C library used by the Signal iOS app for WebRTC interactions."
 
   s.description      = <<-DESC

diff --git a/acknowledgments/acknowledgments.html b/acknowledgments/acknowledgments.html
@@ -732,7 +732,7 @@ <h3 id="AGPL-3.0">GNU Affero General Public License v3.0 (synthesized)</h3>
                 <h4>Used by:</h4>
                 <ul class="license-used-by">
                     <li><a href="https://crates.io/crates/regex-aot">regex-aot 0.1.0</a></li>
-                    <li><a href="https://crates.io/crates/ringrtc">ringrtc 2.34.1</a></li>
+                    <li><a href="https://crates.io/crates/ringrtc">ringrtc 2.34.5</a></li>
                 </ul>
                 <pre class="license-text">GNU AFFERO GENERAL PUBLIC LICENSE
 Version 3, 19 November 2007

diff --git a/acknowledgments/acknowledgments.md b/acknowledgments/acknowledgments.md
@@ -669,7 +669,7 @@ For more information on this, and how to apply and follow the GNU AGPL, see
 
 ```
 
-## regex-aot 0.1.0, ringrtc 2.34.1
+## regex-aot 0.1.0, ringrtc 2.34.5
 
 ```
 GNU AFFERO GENERAL PUBLIC LICENSE

diff --git a/acknowledgments/acknowledgments.plist b/acknowledgments/acknowledgments.plist
@@ -924,7 +924,7 @@ You should also get your employer (if you work as a programmer) or school, if an
 			<key>License</key>
 			<string>GNU Affero General Public License v3.0</string>
 			<key>Title</key>
-			<string>regex-aot 0.1.0, ringrtc 2.34.1</string>
+			<string>regex-aot 0.1.0, ringrtc 2.34.5</string>
 			<key>Type</key>
 			<string>PSGroupSpecifier</string>
 		</dict>
-Original file line number
+Diff line change
@@ Expand Up @@
     ```
-    ## regex-aot 0.1.0, ringrtc 2.34.1
+    ## regex-aot 0.1.0, ringrtc 2.34.5
     ```
     GNU AFFERO GENERAL PUBLIC LICENSE
@@ Expand Down @@