Skip to content

Commit

Permalink
remove unnecessary wandb plot of NA values
Browse files Browse the repository at this point in the history
  • Loading branch information
svandenhaute committed Jun 5, 2024
1 parent b915adb commit 96dd426
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions psiflow/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def _to_wandb(
x_axis = name
for y in ["e_rmse", "f_rmse"]:
key = "delta_" + y
df_na = df[df[key].isna()]
# df_na = df[df[key].isna()]
df_not_na = df[df[key].notna()]

hover_names = []
Expand All @@ -259,14 +259,14 @@ def _to_wandb(
hover_template += s
hover_names.append(name)

figure_ = px.scatter(
data_frame=df_na,
x=x_axis,
y=y,
custom_data=hover_names,
symbol_sequence=["circle"],
color_discrete_sequence=["darkgray"],
)
# figure_ = px.scatter(
# data_frame=df_na,
# x=x_axis,
# y=y,
# custom_data=hover_names,
# symbol_sequence=["circle"],
# color_discrete_sequence=["darkgray"],
# )
figure = px.scatter(
data_frame=df_not_na,
x=x_axis,
Expand All @@ -276,8 +276,8 @@ def _to_wandb(
color_continuous_scale=colors,
symbol_sequence=["circle"],
)
for trace in figure_.data:
figure.add_trace(trace)
# for trace in figure_.data:
# figure.add_trace(trace)
figure.update_traces(
marker={
"size": 10,
Expand Down

0 comments on commit 96dd426

Please sign in to comment.