-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused synonym sync files #759
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the combined cases file - Update the source-specific files so that they now go in tmp/
twhetzel
requested changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out this branch and ran sh run.sh make sync-synonyms -B
to check some things and the mini-build failed:
rm -f components/ordo.db.tmp && \
cat /usr/local/lib/python3.12/dist-packages/semsql/builder//sql_schema/semsql.sql | sqlite3 components/ordo.db.tmp && \
echo .exit | sqlite3 -echo components/ordo.db.tmp -cmd ".mode csv" -cmd ".import config/prefixes.csv prefix" && \
rdftab components/ordo.db.tmp < components/ordo.owl && \
sqlite3 components/ordo.db.tmp -cmd '.separator "\t"' ".import components/ordo-relation-graph.tsv entailed_edge" && \
gzip -f components/ordo-relation-graph.tsv && \
cat /usr/local/lib/python3.12/dist-packages/semsql/builder//indexes/*.sql | sqlite3 components/ordo.db.tmp && \
echo "ALTER TABLE statements ADD COLUMN graph TEXT;" | sqlite3 components/ordo.db.tmp && \
mv components/ordo.db.tmp components/ordo.db
.exit
rm components/ordo-min.owl components/ordo-prefixes.yaml components/ordo-properties.txt
make[1]: Leaving directory '/work/src/ontology'
robot --catalog catalog-v001.xml query -i components/ordo.owl --query ../sparql/synonyms-scope-type-xref.sparql tmp/ordo-synonyms-scope-type-xref.tsv
python3 ../scripts/sync_synonym.py \
--mondo-mappings-path tmp/mondo.sssom.tsv \
--ontology-db-path components/ordo.db \
--mondo-synonyms-path tmp/mondo-synonyms-scope-type-xref.tsv \
--mondo-exclusion-configs config/mondo-exclusion-configs.yml \
--onto-synonym-types-path tmp/ordo-synonyms-scope-type-xref.tsv \
--onto-config-path metadata/ordo.yml \
--outpath-added tmp/ordo.synonyms.added.robot.tsv \
--outpath-confirmed tmp/ordo.synonyms.confirmed.robot.tsv \
--outpath-updated tmp/ordo.synonyms.updated.robot.tsv \
--outpath-combined tmp/synonym_sync_combined_cases_ordo.tsv
awk '(NR == 1) || (NR == 2) || (FNR > 2)' reports/sync-synonym/*.synonyms.added.robot.tsv > reports/sync-synonym/sync-synonyms.added.robot.tsv
awk: cannot open "reports/sync-synonym/*.synonyms.added.robot.tsv" (No such file or directory)
make: *** [mondo-ingest.Makefile:598: reports/sync-synonym/sync-synonyms.added.robot.tsv] Error 2
rm tmp/icd10cm-synonyms-scope-type-xref.tsv tmp/icd10who-synonyms-scope-type-xref.tsv tmp/omim-synonyms-scope-type-xref.tsv tmp/doid-synonyms-scope-type-xref.tsv tmp/icd11foundation-synonyms-scope-type-xref.tsv tmp/ncit-synonyms-scope-type-xref.tsv tmp/ordo-synonyms-scope-type-xref.tsv
Command exited with non-zero status 2
### DEBUG STATS ###
Elapsed time: 33:55.56
Draft
9 tasks
twhetzel
reviewed
Feb 8, 2025
- Delete: The by-source combined case files as well
@twhetzel Was more trouble than it was worth keeping this separate, so I merged it into: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes unused synonym sync file: (i) the combined cases file, (ii) now the source-specific files so that they now go in
tmp/
instead of being committed.Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/
?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingest
on this branch (afterdocker pull obolibrary/odkfull:dev
), and no errors occurred?New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?