Bug fix: KeyError on mondo_label
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This introduced an error later where there was a KeyError on mondo_label (after cls_label was renamed), because it was missing.
Draft
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bug fix: synonyms-scope-type-xref.sparql missing cls_label
This introduced an error later where there was a KeyError on mondo_label (after cls_label was renamed), because it was missing.
This is another bug that slipped in, along with #772, from recent PR #751.
I'm really not sure how both of these build-breaking bugs slipped in. I would the previous build(s) for #751 to have failed.
I also need to merge this now, as this is a critical pipeline-breaking bug, and I immediately need to start running stuff on
develop, so I need this fixed.