Skip to content

Commit

Permalink
Merge pull request #9 from monasticacademy/support-bun
Browse files Browse the repository at this point in the history
add NODE_EXTRA_CA_CERTS to list of env vars in order to support bun
  • Loading branch information
alexflint authored Feb 3, 2025
2 parents bf53180 + 01a7667 commit 3cd4bb5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*.crt
*.pem
*.class
*.har

**/secrets/*
!**/secrets/*.encrypted
Expand Down
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ test-with-node: clean
go run . node experiments/js/get.js

test-with-deno: clean
go run . -- deno --allow-net experiments/deno/get.ts
go run . -- deno --allow-net experiments/ts/get.ts

test-with-bun: clean
go run . -- bun experiments/ts/get.ts

test-with-self: clean
go run . go run . curl https://www.example.com
Expand Down
File renamed without changes.
3 changes: 2 additions & 1 deletion httptap.go
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ func Main() error {
"CURL_CA_BUNDLE="+caPath,
"REQUESTS_CA_BUNDLE="+caPath,
"SSL_CERT_FILE="+caPath,
"DENO_CERT="+caPath,
"DENO_CERT="+caPath, // for deno, which does not read SSL_CERT_FILE
"NODE_EXTRA_CA_CERTS="+caPath, // for bun, which does not read SSL_CERT_FILE
"_JAVA_OPTIONS=-Djavax.net.ssl.trustStore="+caPathPKCS12,
"JDK_JAVA_OPTIONS=-Djavax.net.ssl.trustStore="+caPathPKCS12,
"NODE_EXTRA_CA_CERTS="+caPath,
Expand Down

0 comments on commit 3cd4bb5

Please sign in to comment.