Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Models, Repositories #32

Merged
merged 2 commits into from
Sep 24, 2024
Merged

cleanup Models, Repositories #32

merged 2 commits into from
Sep 24, 2024

Conversation

georgeef
Copy link
Contributor

Changes

  • Cleanup <M>Full in Models. TODO: move AccountWithCurrency to ViewModels.
  • Remove init() in <M>Data (use default initializer, which is equivalent).

File changes

  • In Models, rename <M>.swift -> <M>Data.swift.
  • Move Protocols/ModelsProtocol.swift -> Models/Data.swift (contains shared code for all Models).
  • Move Protocols/RepositoryProtocol.swift -> Repositories/Repository.swift (contains shared code for all Repositories)

@guanlisheng guanlisheng merged commit e25b02e into master Sep 24, 2024
1 check passed
@georgeef georgeef deleted the cleanup_models branch September 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants