support for bitcoin parsing and formatting #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikbosch
force-pushed
the
bitcoin
branch
3 times, most recently
from
ed66e79 to
40dd2c7
Compare
|
I just found out that StyleCI automatically pushes a PR for style inconsistencies. Since I removed the inconsistencies by hand already, I removed those PRs. |
| use Money\MoneyFormatter; | ||
| use Money\Parser\BitcoinSupportedMoneyParser; | ||
|
|
||
| class BitcoinSupportedMoneyFormatter implements MoneyFormatter |
There was a problem hiding this comment.
I can't see a reason why it couldn't be final. WDYT?
|
LGTM. I added a few styling comments. |
|
What is wrong with Travis? Why does it not start? |
|
no clue, travis DERP. Restarted. |
| * @var MoneyFormatter | ||
| */ | ||
| private $delegatedFormatter; | ||
| /** |
|
Two comments added. This is fine from my point of view. I don't use Bitcoin, if anyone has problem with it, we can treat it as bugfix. |
|
Ok. will add the new lines, squash and then merge. |
|
👍 |
frederikbosch
force-pushed
the
bitcoin
branch
from
c805b78 to
33b38d8
Compare
frederikbosch
force-pushed
the
bitcoin
branch
from
33b38d8 to
ead0b05
Compare
frederikbosch
added a commit
that referenced
this pull request
Feb 29, 2016
support for bitcoin parsing and formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97.