-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.2 #715
Support PHP 8.2 #715
Conversation
Closing for now. Wanted to work on this on my own fork first. |
phpspec is not supporting 8.2 yet, but phpspec/phpspec#1435. This is blocking us from adding PHP 8.2 support for now with the current set of requirements. |
With PHP 8.2 now released, it would be nice to have this merged and available :) |
any chance of getting this in? |
Marked PR as ready for review. CI pipeline run requires maintainer approval. |
@frederikbosch Would you mind approving the workflow so that we can see if it's mergable? Thanks 🙏 |
Looks like because of phpspec & prophecy, need to add |
The current CI / Docs error is fixed in master. |
PHPSpec 8.2 support is merged but not yet released (see phpspec/phpspec#1434) @rvanlaak you will have to re-run CI once it is available. |
I fixed PHPSpec CI issues here phpspec/phpspec#1437 |
Hi @frederikbosch, could you re-run the CI steps for PHP 8.2, since its dependencies have been already upgraded? |
Wait, why is there a Update: Could we merge #722 first? |
I believe this was chosen because we were also applying mutation testing, and were planning to use dependabot. See this PR. But, feel free to remove it. I am not against that. I never commit composer.lock in other libs. |
You can cherry pick the last two commits - fix docs and remove composer.lock - from master into this branch to see if CI succeeds now. |
Thank you @frederikbosch |
Great, I was also preparing to do that, but please go ahead. |
See #724 |
Thanks for all your help! |
Seems PHP 8.2 is supported without having to make any changes.
phpspec is not supporting 8.2 yet, but work is in progress. This is blocking us from adding php 8.2 support for now with the current set of requirements.