Add comment to setApplyEmbeddedStyles

moneytoo · Apr 14, 2021 · 1bc1e49 · 1bc1e49
1 parent 890b5d5
commit 1bc1e49
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/app/src/main/java/com/brouken/player/PlayerActivity.java b/app/src/main/java/com/brouken/player/PlayerActivity.java
@@ -1227,6 +1227,10 @@ void updateSubtitleStyle() {
             subtitlesScale = captioningManager.getFontScale();
             if (subtitleView != null) {
                 subtitleView.setUserDefaultStyle();
+                // Do not apply embedded style as currently the only supported color style is PrimaryColour
+                // https://github.com/google/ExoPlayer/issues/8435#issuecomment-762449001
+                // This may result in poorly visible text (depending on user's selected edgeColor)
+                // The same can happen with style provided using setStyle but enabling CaptioningManager should be a way to change the behavior
                 subtitleView.setApplyEmbeddedStyles(false);
             }
         }