Skip to content

fix: better collapse icons #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paula-stacho merged 2 commits into from
Jan 27, 2026
Merged

fix: better collapse icons #179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf7ca1e
fix: better collapse icons
paula-stacho Jan 27, 2026
6342c72
add files
paula-stacho Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/field/field-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import styled from '@emotion/styled';
import { fontWeights } from '@leafygreen-ui/tokens';
import Icon from '@leafygreen-ui/icon';
import { useTheme } from '@emotion/react';
import { useCallback, useEffect, useRef, useState } from 'react';

import { ellipsisTruncation } from '@/styles/styles';
Expand All @@ -11,6 +9,9 @@
import { FieldId, NodeField } from '@/types';
import { useEditableDiagramInteractions } from '@/hooks/use-editable-diagram-interactions';

import { ChevronDown } from '../icons/chevron-down';

Check failure on line 12 in src/components/field/field-content.tsx

View workflow job for this annotation

GitHub Actions / test 

Cannot find module '../icons/chevron-down' or its corresponding type declarations.
import { ChevronUp } from '../icons/chevron-up';

Check failure on line 13 in src/components/field/field-content.tsx

View workflow job for this annotation

GitHub Actions / test 

Cannot find module '../icons/chevron-up' or its corresponding type declarations.

import { FieldNameContent } from './field-name-content';

const FieldContentWrapper = styled.div`
Expand Down Expand Up @@ -46,7 +47,6 @@
}: FieldContentProps) => {
const [isEditing, setIsEditing] = useState(false);
const fieldContentRef = useRef<HTMLDivElement>(null);
const theme = useTheme();

const { onChangeFieldName, onChangeFieldType, fieldTypes, onFieldExpandToggle } = useEditableDiagramInteractions();

Expand Down Expand Up @@ -137,7 +137,7 @@
aria-label={expanded ? 'Collapse Field' : 'Expand Field'}
title={expanded ? 'Collapse Field' : 'Expand Field'}
>
<Icon glyph={expanded ? 'ChevronDown' : 'ChevronLeft'} color={theme.node.fieldIconButton} size={14} />
{expanded ? <ChevronDown /> : <ChevronUp />}
</DiagramIconButton>
)}
</FieldContentWrapper>
Expand Down
2 changes: 1 addition & 1 deletion src/components/field/field-type.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const FieldTypeWrapper = styled.div<{ color: string; placeholderCollapse?: boole
color: ${props => props.color};
font-weight: normal;
padding-left: ${spacing[100]}px;
padding-right: ${props => (props.placeholderCollapse ? spacing[600] : spacing[100])}px;
padding-right: ${props => (props.placeholderCollapse ? spacing[600] : spacing[50])}px;
flex: 0 0 100px;
display: flex;
justify-content: flex-end;
Expand Down
Loading