fix(ci): let the fork workflow use the forked repository and be stricter #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Feb 20, 2025
| @@ -10,7 +10,7 @@ permissions: | |||
| jobs: | |||
| test-and-build: | |||
| name: Test and Build | |||
| if: github.event.pull_request.user.login == 'dependabot[bot]' || github.event.pull_request.head.repo.full_name != github.repository | |||
| if: github.event.pull_request.user.login == 'dependabot[bot]' && github.event.pull_request.head.repo.full_name != github.repository | |||
There was a problem hiding this comment.
I assume this is unintentional and we'd want to be strict about this?
There was a problem hiding this comment.
I don't get this second term, actually. If the pull request's repo ISN'T this one?
There was a problem hiding this comment.
Oh I see it is happening from a fork, not a branch in this repo? But I'm looking at past dependabot PRs (such as this one #956) and they seem to just be branches on this repo. Where are the forks?
There was a problem hiding this comment.
oh nevermind, I thought this was workflow was meant only for dependabot which forked the repo but I guess it's meant to be external users or dependabot. but the latter condition is basically a way of checking "this is a fork"
gagik
added
the
no-title-validation
gagik
changed the title
lerouxb
approved these changes
Feb 20, 2025
gagik
force-pushed
the
gagik/fix-fork-workflow
branch
from
1ce6902 to
73e233a
Compare
gagik
force-pushed
the
gagik/fix-fork-workflow
branch
from
73e233a to
6a892da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/mongodb-js/vscode/actions/runs/13435011260/job/37535233590?pr=959 we see that the intentionally failing tests aren't failing. We need to be explicit about the repository to check out in this case.