Skip to content

DOCSP-42484 - Remove LINQ2 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Sep 17, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42484
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for mongodb-docs-csharp ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66eb305ec5371d92874edfb8
😎 Deploy Preview https://deploy-preview-229--mongodb-docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongoKart mongoKart requested review from a team, adelinowona and rstam and removed request for a team and adelinowona September 17, 2024 17:52
LINQ3 is the only LINQ provider available in the {+driver-long+}. If you have
manually configured your project to use LINQ2, you must change your provider to
LINQ3 to use this version of the driver.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rstam IIRC LINQ provider configuration option was removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had meant this to refer to whatever custom configuration some users might have done to stick with LINQ2 after LINQ3 became the default. Is there a better way to phrase this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MongoClientSettings LinqProvider property has been removed.

If the client has code to configure the client settings to use LINQ2 it will no longer compile.

They need to remove that code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

LINQ3 is the only LINQ provider available in the {+driver-long+}. If you have
manually configured your project to use LINQ2, you must change your provider to
LINQ3 to use this version of the driver.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MongoClientSettings LinqProvider property has been removed.

If the client has code to configure the client settings to use LINQ2 it will no longer compile.

They need to remove that code.

@mongoKart mongoKart requested a review from rstam September 18, 2024 17:06
Copy link
Collaborator

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart merged commit 6622421 into mongodb:v3.0 Sep 19, 2024
2 of 7 checks passed
@mongoKart mongoKart deleted the docsp-42484-remove-linq2 branch September 19, 2024 17:14
mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants